[tests] Added smoke tests for conv solvers (ConvAsmBwdWrW1x1 and more). Some fixes. #1906

atamazov · 2022-12-19T14:06:00Z

@junliume https://github.com/ROCmSoftwarePlatform/MIOpen/labels/testing https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_high

Proposed reviewers: @averinevg @xinpin -- mostly to share knowledge, plus @shurale-nkn

TODO

Add GFX110X_ENABLED where necessary.

This PR adds smoke tests for conv solvers:

ConvAsmBwdWrW1x1 (with tuning)
ConvAsmBwdWrW3x3 (with tuning)
ConvAsmImplicitGemmGTCDynamicFwdXdlopsNHWC (with tuning)
ConvAsmImplicitGemmGTCDynamicBwdXdlopsNHWC (with tuning)
ConvAsmImplicitGemmGTCDynamicWrwXdlopsNHWC (with tuning)
ConvAsmImplicitGemmGTCDynamicFwdDlopsNCHWC (with tuning)
ConvCkIgemmFwdV6r1DlopsNchw (with tuning)
ConvHipImplicitGemmV4R1Fwd (with tuning)
ConvHipImplicitGemmV4R4Fwd (with tuning)
ConvHipImplicitGemmV4R4WrW (with tuning)
ConvHipImplicitGemmV4R1WrW (with tuning)
ConvHipImplicitGemmBwdDataV4R1 (with tuning)
ConvHipImplicitGemmBwdDataV1R1 (with tuning)
ConvHipImplicitGemmBwdDataV4R1Xdlops (with tuning)
ConvHipImplicitGemmForwardV4R4Xdlops (with tuning)
ConvHipImplicitGemmForwardV4R4Xdlops_Padded_Gemm (with tuning)
ConvHipImplicitGemmBwdDataV1R1Xdlops (with tuning)
ConvHipImplicitGemmFwdXdlops (with tuning)
ConvHipImplicitGemmForwardV4R5Xdlops (with tuning)
ConvHipImplicitGemmWrwV4R4Xdlops (with tuning)
ConvHipImplicitGemmWrwV4R4Xdlops_Padded_Gemm (with tuning)
ConvMlirIgemmFwd/Bwd/WrW (with tuning). Removed test_conv_igemm_mlir_small.
ConvMlirIgemmFwd/Bwd/WrWXdlops(with tuning). Removed test_conv_igemm_mlir_xdlops_small.
ConvBinWinogradRxSf2x3 (with tuning)
ConvBinWinogradRxSf2x3g1
ConvBinWinogradRxSf3x2 (with tuning)

By products:

[CMake][Fix] Fix issue in set_var_to_condition, see [HIP][COMGR] Use COMGR by default for HIP backend #1253 (review)
[NFC] ConvHipImplicitGemmBwdDataV1R1:
- Improve W/A for issue [BF16] ConvHipImplicitGemmBwdDataV1R1: Memory access faults. #309.
- Do not observe FP16_ALT attribute (it is irrelevant as FP16 is not supported).
[tests][NFC]
- Rename custom tests: smoke_conv_solver_Conv* -> smoke_solver_Conv*
- Added SKIP_UNLESS_COMPOSABLEKERNEL option for custom tests
- Added support for the "--output_type" option of test_conv.
- Removed unnecessary MIOPEN_TEST_FLOAT_ARG from test_conv commands where TEST_CONV_VERBOSE_F/B/W is already used.
- Rename couple of solver tests for clarity.
- [NFC] Rename cmake variable: TEST_ANY_ERROR -> TEST_TUNING

…icitGemmGTCDynamicWrwXdlopsNHWC.

…plicitGemmGTCDynamic(Fwd|Bwd)Xdlops

…h results in omission of all custom tests

…uning)

… from header

…TERATIONS_MAX

…1x1U

…d() check from ConvAsm1x1UV2 is it does not support FP16

…th tuning)

…CLEAN

…ltipassWrW (3-3 only)

…t potential performance degradation after tests.

… tuning)

…mmGTCDynamicFwdXdlopsNHWC

…mmGTCDynamicBwdXdlopsNHWC

…mmGTCDynamicWrwXdlopsNHWC

…mmGTCDynamicFwdDlopsNCHWC

… tests

src/solver/conv_asm_1x1u_stride2.cpp

…t-solver-03 # RESOLVED Conflicts: # test/CMakeLists.txt

# RESOLVED Conflicts: # test/CMakeLists.txt

junliume · 2023-01-31T06:40:41Z

@junliume @johnny-keker Ready for CI testing & review/merge!

Started CI on the latest commit.

junliume · 2023-02-05T01:55:21Z

@junliume @johnny-keker Ready for the next round of CI testing.

@atamazov this PR has some issues with smoke_solver_ConvHipImplicitGemmFwdXdlops on gfx908

log.txt

atamazov · 2023-02-07T22:51:08Z

@junliume

@atamazov this PR has some issues with smoke_solver_ConvHipImplicitGemmFwdXdlops on gfx908

The reason is #1971

# RESOLVED Conflicts: # test/CMakeLists.txt

…moke_solver_Conv*

…ST_FLOAT_ARG where TEST_CONV_VERBOSE_F/B/W is already used.

junliume · 2023-02-24T04:44:51Z

@junliume @johnny-keker Ready for the next round of CI testing.

CI started

# RESOLVED Conflicts: # src/solver/conv_hip_implicit_gemm_bwd_v1r1.cpp

atamazov · 2023-03-03T15:09:51Z

@junliume @johnny-keker Wait... there is an issue in smoke_solver_ConvHipImplicitGemmV4R1

junliume · 2023-03-03T17:03:03Z

@junliume @johnny-keker Wait... there is an issue in smoke_solver_ConvHipImplicitGemmV4R1

@atamazov We recently updated it via #2005

…o override WORKAROUND_iGemm_936 from Jenkinsfile.

atamazov · 2023-03-03T17:06:03Z

@junliume Thanks, I see. This is different issue related to W/A for #936 in Jenkinsfile.

@junliume @johnny-keker Ready for the next round of CI testing.

atamazov · 2023-03-07T15:37:32Z

@junliume https://github.com/ROCmSoftwarePlatform/MIOpen/labels/TESTING_CI_PASSED can we go ahead and merge?

atamazov · 2023-03-08T19:24:33Z

@junliume Thanks!

atamazov · 2023-03-09T18:16:32Z

test/CMakeLists.txt

+add_custom_test(smoke_solver_ConvBinWinogradRxSf2x3g1 GFX900_DISABLED GFX103X_ENABLED HALF_ENABLED SKIP_XNACK_ON
+    COMMAND MIOPEN_DEBUG_CONVOLUTION_ATTRIB_FP16_ALT_IMPL=0
+      MIOPEN_FIND_MODE=normal MIOPEN_DEBUG_FIND_ONLY_SOLVER=ConvBinWinogradRxSf2x3g1 $<TARGET_FILE:test_conv2d>
+      --input 1 40 20 20 --weights 20 40 3 3 --pads_strides_dilations 1 1 1 1 1 1 ${MIOPEN_TEST_FLAGS_ARGS}
+)


This is duplicate. Will be removed in next PR.

…). Some fixes. (#1906)

atamazov added 30 commits November 17, 2022 17:39

ata-test-solver-02(01) [NFC] Typo in the error message in ConvAsmImpl…

122de35

…icitGemmGTCDynamicWrwXdlopsNHWC.

ata-test-solver-02(02) [tests] Added smoke test for solvers ConvAsmIm…

36ad705

…plicitGemmGTCDynamic(Fwd|Bwd)Xdlops

ata-test-solver-02(03) [tests] Added smoke test for ConvBinWinograd3x3U

fa5c77c

ata-test-solver-02(04) [tests] Added smoke test for ConvBinWinogradRxS

a5d96c1

ata-test-solver-02(05) [tests] Added smoke test for ConvOclBwdWrW53

6d0721e

ata-test-solver-02(06) [HOTFIX][tests] Fixed defect in ROCm#1844 whic…

e6ff153

…h results in omission of all custom tests

ata-test-solver-02(07) [tests] Added smoke test for ConvOclBwdWrW1x1

a3266e7

ata-test-solver-02(08) [tests] Added smoke test for fft

b8fca13

ata-test-solver-02(09) [tests] Added smoke test for ConvDirectNaiveConv

8a3b199

ata-test-solver-02(10) [tests] Print datatype used for testing

69c0063

ata-test-solver-02(11) [tests] Added smoke test for ConvAsm1x1U (no t…

cf8788f

…uning)

ata-test-solver-02(12) [NFC][tuning] Factor out some inline functions…

5b92535

… from header

ata-test-solver-02(13) [tuning] Add support for MIOPEN_DEBUG_TUNING_I…

076fe70

…TERATIONS_MAX

ata-test-solver-02(14) [tuning] Cleaner logging during tuning

a81434e

ata-test-solver-02(15) [tests] Added tuning to smoke test for ConvAsm…

049514d

…1x1U

ata-test-solver-02(16) [NFC] Removed excessive IsGfx90aFp16altRequire…

ef476c0

…d() check from ConvAsm1x1UV2 is it does not support FP16

ata-test-solver-02(17) [tests] Added smoke test for ConvAsm1x1UV2 (wi…

0637230

…th tuning)

ata-test-solver-02(18) [tests] Use MIOPEN_USER_DB_PATH instead of DB_…

daa7a0f

…CLEAN

ata-test-solver-02(19) [tests] Added smoke test for ConvWinograd3x3Mu…

094cbaf

…ltipassWrW (3-3 only)

ata-test-solver-02(20) [Fix][tests] Use MIOPEN_USER_DB_PATH to preven…

f557eea

…t potential performance degradation after tests.

ata-test-solver-02(21) Merge branch 'develop' into ata-test-solver-02

5e1bc85

ata-test-solver-02(22) [tests] Added smoke test for ConvAsm3x3U (with…

f9ce39f

… tuning)

ata-test-solver-03(01) [tests] Added smoke test for ConvAsmBwdWrW1x1

c12b4aa

ata-test-solver-03(02) [tests] Added smoke test for ConvAsmBwdWrW3x3

831d6cf

ata-test-solver-03(03) [tests] Added smoke test for ConvAsmImplicitGe…

3d86427

…mmGTCDynamicFwdXdlopsNHWC

ata-test-solver-03(04) [tests] Added smoke test for ConvAsmImplicitGe…

30911f2

…mmGTCDynamicBwdXdlopsNHWC

ata-test-solver-03(05) [tests] Added smoke test for ConvAsmImplicitGe…

7058fbf

…mmGTCDynamicWrwXdlopsNHWC

ata-test-solver-03(06) [tests] Added smoke test for ConvAsmImplicitGe…

cda245c

…mmGTCDynamicFwdDlopsNCHWC

ata-test-solver-03(07) [tests] Added missing TEST_ANY_ERROR to tuning…

eaf9db0

… tests

ata-test-solver-03(08) [tests] TEST_ANY_ERROR -> TEST_TUNING

c3daed0

junliume reviewed Jan 15, 2023

View reviewed changes

src/solver/conv_asm_1x1u_stride2.cpp Outdated Show resolved Hide resolved

atamazov added 5 commits January 16, 2023 17:40

ata-test-solver-02(25) Fixed cppcheck issue

cee5255

ata-test-solver-02(27) Merge branch 'develop' into ata-test-solver-02

14ca75e

ata-test-solver-03(43) Merge branch 'ata-test-solver-02' into ata-tes…

cab2b9c

…t-solver-03 # RESOLVED Conflicts: # test/CMakeLists.txt

ata-test-solver-03(44) Merge branch 'develop' into ata-test-solver-03

fbfcc1b

ata-test-solver-03(45) Merge branch 'develop' into ata-test-solver-03

04ee871

# RESOLVED Conflicts: # test/CMakeLists.txt

atamazov marked this pull request as ready for review January 30, 2023 13:15

ata-test-solver-03(46) Merge branch 'develop' into ata-test-solver-03

3000004

atamazov mentioned this pull request Feb 7, 2023

[CK] UB when invoker of ConvHipImplicitGemmFwdXdlops is called #1971

Closed

atamazov mentioned this pull request Feb 8, 2023

[HOTFIX][CK] Do not call solver member functions in Invokers of ConvHipImplicitGemmFwd/BwdXdlops #1972

Merged

atamazov added 4 commits February 10, 2023 15:06

ata-test-solver-03(47) Merge branch 'develop' into ata-test-solver-03

9199882

ata-test-solver-03(48) Merge branch 'develop' into ata-test-solver-03

a3401a2

# RESOLVED Conflicts: # test/CMakeLists.txt

ata-test-solver-03(49) [tests][NFC] more smoke_conv_solver_Conv* -> s…

9b30926

…moke_solver_Conv*

ata-test-solver-03(50) [tests] More removals of unnecessary MIOPEN_TE…

775b2ad

…ST_FLOAT_ARG where TEST_CONV_VERBOSE_F/B/W is already used.

ata-test-solver-03(51) Merge branch 'develop' into ata-test-solver-03

47d3496

# RESOLVED Conflicts: # src/solver/conv_hip_implicit_gemm_bwd_v1r1.cpp

ata-test-solver-03(52) Explicitly enable ConvHipImplicitGemmV4R1Fwd t…

eab21d1

…o override WORKAROUND_iGemm_936 from Jenkinsfile.

junliume added the TESTING_CI_PASSED label Mar 8, 2023

junliume approved these changes Mar 8, 2023

View reviewed changes

junliume merged commit 6fde4a8 into ROCm:develop Mar 8, 2023

atamazov commented Mar 9, 2023

View reviewed changes

alexandraBara pushed a commit that referenced this pull request Mar 14, 2023

[tests] Added smoke tests for conv solvers (ConvAsmBwdWrW1x1 and more…

837cf48

…). Some fixes. (#1906)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tests] Added smoke tests for conv solvers (ConvAsmBwdWrW1x1 and more). Some fixes. #1906

[tests] Added smoke tests for conv solvers (ConvAsmBwdWrW1x1 and more). Some fixes. #1906

atamazov commented Dec 19, 2022 •

edited

Loading

junliume commented Jan 31, 2023

junliume commented Feb 5, 2023

atamazov commented Feb 7, 2023

junliume commented Feb 24, 2023

atamazov commented Mar 3, 2023

junliume commented Mar 3, 2023 •

edited

Loading

atamazov commented Mar 3, 2023

atamazov commented Mar 7, 2023

atamazov commented Mar 8, 2023

atamazov Mar 9, 2023

[tests] Added smoke tests for conv solvers (ConvAsmBwdWrW1x1 and more). Some fixes. #1906

[tests] Added smoke tests for conv solvers (ConvAsmBwdWrW1x1 and more). Some fixes. #1906

Conversation

atamazov commented Dec 19, 2022 • edited Loading

TODO

This PR adds smoke tests for conv solvers:

By products:

junliume commented Jan 31, 2023

junliume commented Feb 5, 2023

atamazov commented Feb 7, 2023

junliume commented Feb 24, 2023

atamazov commented Mar 3, 2023

junliume commented Mar 3, 2023 • edited Loading

atamazov commented Mar 3, 2023

atamazov commented Mar 7, 2023

atamazov commented Mar 8, 2023

atamazov Mar 9, 2023

Choose a reason for hiding this comment

atamazov commented Dec 19, 2022 •

edited

Loading

junliume commented Mar 3, 2023 •

edited

Loading